Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users of the executor hook actions should be forced to only use the action once. #798

Closed
shawn-hurley opened this issue Feb 28, 2018 · 2 comments
Labels
3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 tech-debt

Comments

@shawn-hurley
Copy link
Contributor

Bug:

Currently a user could call finishWithError and then call finishWithSuccess on the executor.

What happened:
Success overwrote the error.

What you expected to happen:
Once finish is called, we should not be able to call another finish action.

@shawn-hurley shawn-hurley added bug tech-debt 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 labels Feb 28, 2018
@jmrodri
Copy link
Contributor

jmrodri commented Feb 28, 2018

I don't think it should be an error condition that could cause things to go bad on the sender side. I'd rather log the error that we detected a success following an error and possibly print out the caller information we might have. Then we should fix the caller to not do that.

I would probably prevent the overwrite though while doing the logging.

@jmrodri
Copy link
Contributor

jmrodri commented May 17, 2018

Closing, hasn't been an issue.

@jmrodri jmrodri closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 tech-debt
Projects
None yet
Development

No branches or pull requests

2 participants