Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a configuration switch that will execute APBs in ansible verbose mode for debugging purposes. #822

Closed
eriknelson opened this issue Mar 8, 2018 · 14 comments
Assignees
Labels
3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 docs feature lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@eriknelson
Copy link
Contributor

Came up on the CEE call. SSIA.

@eriknelson eriknelson self-assigned this Mar 8, 2018
@shawn-hurley
Copy link
Contributor

I think that this should be a generic flag, that tells a bundle to run in verbose mode and the base for that bundle know's how to translate that?

@eriknelson
Copy link
Contributor Author

@shawn-hurley what do you mean generic flag? something other than a setting in the configmap? Was thinking something like _apb_verbose_output and the base would tack on -vvv in its presence.

@shawn-hurley
Copy link
Contributor

I was thinking something like _bundle_verbose_output.

@eriknelson
Copy link
Contributor Author

Ah right. That's more correct, I would just request that we update all of the flags so things remain consistent, which is probably 2 PRs.

First: move from _apb -> _bundle, which means updating docs and images. Then add this flag in a follow up.

@jmrodri
Copy link
Contributor

jmrodri commented Mar 10, 2018

Funny, I thought it would be cool to have an endpoint on the broker that could have it dump debug information as well. I'll formulate a better idea and create an issue for this scenario.

@rthallisey rthallisey added the 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 label Mar 19, 2018
@rthallisey
Copy link
Contributor

execute ansible with -vvvvvv

@jmrodri
Copy link
Contributor

jmrodri commented Mar 20, 2018

[09:53] <@jmrodri> or is it purely a pass through to the bundle?
[09:53] <@ernelson> jmrodri: I think it's a passthrough
[09:53] <@shurley> +1

@eriknelson eriknelson changed the title Consider a configuration switch that will execute APBs in verbose mode for debugging purposes. Consider a configuration switch that will execute APBs in ansible verbose mode for debugging purposes. Mar 20, 2018
@eriknelson
Copy link
Contributor Author

See ansible -vvv flag.

@mhrivnak
Copy link
Member

During the IRC meeting just now, it was agreed that this should be a generic setting that is not ansible-specific. Lots of things have a verbose mode and could make use of this flag. Suggested actions:

  • add the setting to the bundle contract document
  • define that a service bundle should make a best effort to generate verbose output when the setting is true

@djzager
Copy link
Member

djzager commented Mar 20, 2018

Just wanted to point out in here. That one of the things I learned from the helm registry adapter experiment, creating Specs from scratch, is that it is possible for us to add (from the broker) this verbose flag as a parameter to all plans such that Service Bundle Developers would not have to explicitly add this as a parameter.

Example:

apb.ParameterDescriptor{
    Name:            "verbose",
    Title:               "Verbose",
    Type:              "boolean",
    Default:           false,
    Updatable:      flase,
    Required:        false,
},

@jmrodri jmrodri added 3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 and removed 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 labels May 29, 2018
@jmrodri
Copy link
Contributor

jmrodri commented Jul 23, 2018

@djzager this looks very useful, how hard do you think it would be to implement this?

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2020
@jmrodri
Copy link
Contributor

jmrodri commented Sep 20, 2020

/close

@openshift-ci-robot
Copy link

@jmrodri: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 docs feature lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

8 participants