Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default development template whitelist to * #823

Closed
dymurray opened this issue Mar 8, 2018 · 3 comments · Fixed by #827
Closed

Change default development template whitelist to * #823

dymurray opened this issue Mar 8, 2018 · 3 comments · Fixed by #827
Assignees

Comments

@dymurray
Copy link
Member

dymurray commented Mar 8, 2018

For development we don't want to enforce a whitelist in the local registry adapter because new APB developers do not realize that they have to name their APB $name-apb. Let's change the default behavior to allow all naming conventions unless the user explicitly changes it since this template will be used for development.

@eriknelson
Copy link
Contributor

We don't really have a development template, per se? It's really just the one deployment template. My gut reaction is I'm a little concerned with opening this up, but I understand the complaint. I also definitely do not want to add more specialized deployment templates that we have to support.

How are these folks usually bringing up their cluster and broker? run_lastest_build.sh and minishift? Can we add some logic that maybe patches the deployment instead of the default template value?

@shawn-hurley
Copy link
Contributor

My initial reaction is that the deployment templates are all for development, and openshift-ansible is the way to install for prod use cases.

I am not opposed to making the default white_list a parameter for the template, we could make this updatable. I say we keep the default to "*" though.

@eriknelson
Copy link
Contributor

@shawn-hurley that sounds reasonable. As discussed in IRC, let's call out the fact that we're defaulting to open. Otherwise, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants