Bindable APB Provision fails if credentials are not created

[djzager]

Bug:

If an APB (or more generically a Service Bundle) is bindable, but does not encode bind credentials as part of the provision step (ie. asb_encode_binding) then the Broker will look for credentials that do not exist and fail.

The error message:

Provision APB error: Unable to retrieve secret [ apb-7facd926-565f-4439-adaf-f47edb46fc5f ] - secrets "apb-7facd926-565f-4439-adaf-f47edb46fc5f" not found

How to reproduce it:

Create an APB with bindable: True, do not encode bind credentials on provision, provision the APB.

[pb82]

When this happens you will get an error in your service instance that says: Provision call failed: Error occurred during provision. Please contact administrator if it persists.. This is not correct because provision did succeed. You will see this error even when you choose not to bind at provision-time.

The errors in the asb logs were:

[2018-03-22T09:45:44.447Z] [ERROR] - Unable to load secret 'apb-5cf1a88b-7e8f-4644-b2a6-2ce942726fc1' from namespace 'localregistry-unifiedpush-apb-prov-d5f9s'
[2018-03-22T09:45:44.448Z] [ERROR] - apb::provision error occurred - Unable to retrieve secret [ apb-5cf1a88b-7e8f-4644-b2a6-2ce942726fc1 ] - secrets "apb-5cf1a88b-7e8f-4644-b2a6-2ce942726fc1" not found

[jmrodri]

Moving this to release-1.4 because this is not a trivial fix.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[jmrodri]

/close

[openshift-ci-robot]

@jmrodri: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.