successful bootstrap logs tons of misleading error messages

[mhrivnak]

What happened:
I started the broker, and the log is full of error messages that are misleading.

What you expected to happen:
No misleading error messages.

How to reproduce it:
Start the broker, and look at the log.

No runtime label
There were nearly 30 of these messages. It was looking at images that are not service bundles, so they would not be expected to have a runtime label.

time="2018-03-29T20:39:50Z" level=info msg="No runtime label found. Set runtime=1. Will use 'exec' to gather bind credentials"
time="2018-03-29T20:39:50Z" level=info msg="No runtime label found. Set runtime=1. Will use 'exec' to gather bind credentials"
time="2018-03-29T20:39:50Z" level=info msg="No runtime label found. Set runtime=1. Will use 'exec' to gather bind credentials"
time="2018-03-29T20:39:50Z" level=info msg="No runtime label found. Set runtime=1. Will use 'exec' to gather bind credentials"
time="2018-03-29T20:39:50Z" level=info msg="No runtime label found. Set runtime=1. Will use 'exec' to gather bind credentials"
time="2018-03-29T20:39:50Z" level=info msg="No runtime label found. Set runtime=1. Will use 'exec' to gather bind credentials"
time="2018-03-29T20:39:50Z" level=info msg="No runtime label found. Set runtime=1. Will use 'exec' to gather bind credentials"

Version out of bounds
These messages shouldn't be logged at all. They are looking at images that are not service bundles, hence why the version field is empty.

time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."
time="2018-03-29T20:39:50Z" level=warning msg="Spec [  ] failed validation for the following reason: [ APB Spec version [] out of bounds 1.0 <= 1.0 ]. It will not be made available."

[jmrodri]

one thought I had would be to gather this information and print a summary report after bootstrap is done.

the information is useful for debugging problems.

Maybe the report could say

out of bound spec versions: 10
valid specs: 5
blah blah blah : 3
total specs processed : 18

I'll get a better example

[mhrivnak]

Agreed 100%. It's useful info if presented well. I think it's useful to log one line about each spec either way, and then a summary at the end could help give a bigger picture. Some thoughts:

• If there is an error with a spec, the error should come with some info about which spec it was so a human can investigate.
• If a spec loads successfully, it's still worth logging that at INFO I think, again with enough info to know which spec.
• If an image is determined to not be a service bundle, that should normally be omitted from log output. It's not helpful unless you're investigating a very particular problem getting a bundle to be recognized. I'd log this at DEBUG, and again be real clear about which image it is.
• Knowing how many were loaded from each configured registry could be helpful in the summary. That's a quick way to sanity-check "I know there are X bundles in this registry, and I see that X bundles were loaded from it."

[shawn-hurley]

I think that this should be fixed in bundle-lib automationbroker/bundle-lib#50 going to close