Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Distribution isn't supported as a Ansible Service Broker registry #877

Closed
Jmainguy opened this issue Apr 4, 2018 · 6 comments
Closed
Assignees
Labels
3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 feature

Comments

@Jmainguy
Copy link

Jmainguy commented Apr 4, 2018

Feature:

The number and types of Ansible Service Broker Registrys that are supported are very limited. Our company would like to use Jfrog's Artifactory, but at a minimum, I would hope that a regular v2 distrubution end point would be supported. Would be great if you added v2 distrubution as supported registry fro Ansible Service Broker

What happened:
Tried using ansible service broker registry, was dissapointed when I could not
What you expected to happen:
I expected it to support docker distribution/registries, like pulp, or docker distribution, or jfrog aritfactory.
How to reproduce it:
Try and use any regular v2 docker distribution endpoint, it isnt currently supported.

@jwmatthews
Copy link
Member

We use the Docker v2 Catalog API for discovery. If a registry supports that... than we have the big pieces we need for the adapter to function.

We have not tested against JFrog Artifactory before.
According to https://www.jfrog.com/jira/browse/RTFACT-8206 they support _catalog API endpoint.

@Jmainguy if you would provide us with a registry endpoint to test against we can try to get an adapter working.

@dymurray
Copy link
Member

dymurray commented Apr 4, 2018

+1 to getting a registry endpoint to test against. Our dockerhub adapter can be repurposed to work with any generic docker v2 distribution fairly easily I believe.

@jwmatthews
Copy link
Member

Created trello card for RFE of supporting JFrog Artifactory with a registry adapter:
https://trello.com/c/G08oJpJh

@Jmainguy
Copy link
Author

Jmainguy commented Apr 4, 2018

You should be able to hit this endpoint now.

curl https://jmainguy-docker-local.jfrog.io/v2/_catalog -u anonymous:anonymous

https://jmainguy-docker-local.jfrog.io/v2/_catalog

@dymurray dymurray self-assigned this Apr 10, 2018
@rthallisey rthallisey added feature 3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 labels Apr 10, 2018
@johnkim76 johnkim76 self-assigned this Apr 25, 2018
@jmrodri
Copy link
Contributor

jmrodri commented Jul 23, 2018

Fixed by a bunch of PRs to bundle-lib
https://github.com/automationbroker/bundle-lib/pulls?q=is%3Apr+apiv2+is%3Aclosed

@jmrodri jmrodri closed this as completed Jul 23, 2018
@Jmainguy
Copy link
Author

Yall are the best, thank you for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 feature
Projects
None yet
Development

No branches or pull requests

6 participants