Binding errors are no longer displayed

[pb82]

Bug:

Binding errors are no longer displayed in the Create binding dialog.

What happened:

In the release-1.1 tag when a binding failed (by using fail in the ansible role) an error was shown in the dialog and the binding was marked with Error:

That does no longer seem to be the case in more recent versions (tested with the canary and sprint-147.2 tags). The binding appears to be successful even though the pod running the ansible role shows a failure:

This is how the dialog looked like in that case:

What you expected to happen:

The binding dialog should show an error when the pod running the ansible role fails.

How to reproduce it:

Use the sprint-147.2 tag of the ASB and create a bind role that will error (by using fail in ansible). Trigger that binding.

[jmrodri]

Using the following bind playbook, I was able to see the failure in the UI:

- name: Create a user, password, and database
  hosts: localhost
  gather_facts: false
  connection: local
  roles:
  - role: ansible.kubernetes-modules
    install_python_requirements: no
  - role: ansibleplaybookbundle.asb-modules
  - role: bind-rhscl-postgresql-apb-openshift
    playbook_debug: false
  pre_tasks:
    - fail:
      msg: "bind that always fails"

UI failure:

The log snippet shows the binding starting, running, and finally failed.

time="2018-08-01T19:45:00Z" level=debug msg="set job state for instance: 601c02ca-95c3-11e8-8b05-0242ac11000c token: b0e3ecba-3871-44fd-b96d-fa0b27bc037a"
time="2018-08-01T19:45:00Z" level=debug msg="set binding instance: 601c02ca-95c3-11e8-8b05-0242ac11000c"
time="2018-08-01T19:45:00Z" level=info msg="============================================================"
time="2018-08-01T19:45:00Z" level=info msg="                       BINDING                              "
time="2018-08-01T19:45:00Z" level=info msg="============================================================"
time="2018-08-01T19:45:00Z" level=info msg="ServiceInstance.ID: 1dda1477cace09730bd8ed7a6505607e"
time="2018-08-01T19:45:00Z" level=info msg="ServiceInstance.Name: dh-postgresql-apb"
time="2018-08-01T19:45:00Z" level=info msg="ServiceInstance.Image: docker.io/jmrodri/postgresql-apb:latest"
time="2018-08-01T19:45:00Z" level=info msg="ServiceInstance.Description: SCL PostgreSQL apb implementation"
time="2018-08-01T19:45:00Z" level=info msg="============================================================"
time="2018-08-01T19:45:00Z" level=debug msg="executor::actionStarted"
time="2018-08-01T19:45:00Z" level=debug msg="JobStateSubscriber Notify : msg state {b0e3ecba-3871-44fd-b96d-fa0b27bc037a in progress  bind  action started} "
time="2018-08-01T19:45:00Z" level=debug msg="set job state for instance: 601c02ca-95c3-11e8-8b05-0242ac11000c token: b0e3ecba-3871-44fd-b96d-fa0b27bc037a"
...
time="2018-08-01T19:45:01Z" level=debug msg="get binding instance: 601c02ca-95c3-11e8-8b05-0242ac11000c"
time="2018-08-01T19:45:01Z" level=debug msg="service_id: 1dda1477cace09730bd8ed7a6505607e"
time="2018-08-01T19:45:01Z" level=debug msg="plan_id: 7f4a5e35e4af2beb70076e72fab0b7ff"
time="2018-08-01T19:45:01Z" level=debug msg="operation:  b0e3ecba-3871-44fd-b96d-fa0b27bc037a"
time="2018-08-01T19:45:01Z" level=debug msg="state: in progress"
time="2018-08-01T19:45:01Z" level=debug msg="description: action started"
172.17.0.11 - - [01/Aug/2018:19:45:01 +0000] "GET /openshift-automation-service-broker/v2/service_instances/2918e9f7-95c3-11e8-8b05-0242ac11000c/service_bindings/601c02ca-95c3-11e8-8b05-0242ac11000c/last_operation?operation=b0e3ecba-3871-44fd-b96d-fa0b27bc037a&plan_id=7f4a5e35e4af2beb70076e72fab0b7ff&service_id=1dda1477cace09730bd8ed7a6505607e HTTP/1.1" 200 64
...
time="2018-08-01T19:45:07Z" level=debug msg="get binding instance: 601c02ca-95c3-11e8-8b05-0242ac11000c"
time="2018-08-01T19:45:07Z" level=debug msg="service_id: 1dda1477cace09730bd8ed7a6505607e"
time="2018-08-01T19:45:07Z" level=debug msg="plan_id: 7f4a5e35e4af2beb70076e72fab0b7ff"
time="2018-08-01T19:45:07Z" level=debug msg="operation:  b0e3ecba-3871-44fd-b96d-fa0b27bc037a"
time="2018-08-01T19:45:07Z" level=debug msg="state: failed"
time="2018-08-01T19:45:07Z" level=debug msg="description: Error occurred during bind. Please contact administrator if the issue persists."
time="2018-08-01T19:45:07Z" level=debug msg="job state has an error. Assuming that any error here is human readable. err - Pod [ bundle-f9e6bc86-3f98-4f0c-ae85-c02d334dcf63 ] failed with exit code [2]"
172.17.0.11 - - [01/Aug/2018:19:45:07 +0000] "GET /openshift-automation-service-broker/v2/service_instances/2918e9f7-95c3-11e8-8b05-0242ac11000c/service_bindings/601c02ca-95c3-11e8-8b05-0242ac11000c/last_operation?operation=b0e3ecba-3871-44fd-b96d-fa0b27bc037a&plan_id=7f4a5e35e4af2beb70076e72fab0b7ff&service_id=1dda1477cace09730bd8ed7a6505607e HTTP/1.1" 200 124

This is using OpenShift 3.10 with a release-1.2 broker:

$ oc version
oc v3.10.0-rc.0+745de5b-46-dirty
kubernetes v1.10.0+b81c8f8
features: Basic-Auth GSSAPI Kerberos SPNEGO
Server https://172.17.0.1:8443
openshift v3.10.0-rc.0+745de5b-46
kubernetes v1.10.0+b81c8f8