Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc link for complicated parameters #973

Closed
dimitraz opened this issue May 31, 2018 · 6 comments
Closed

Doc link for complicated parameters #973

dimitraz opened this issue May 31, 2018 · 6 comments
Assignees
Labels
feature lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. unplanned Issue is recognized but not planned for any release

Comments

@dimitraz
Copy link

This form is for bug reports and feature requests. Major features will go through a spec process.

Feature:

We have some slightly more involved parameters that benefit from an external link to their relative documentation. At the moment we've added full urls to the description, which doesn't seem like a great user experience.
Is there a better way to do this currently? If there isn't, would this be a feature that is likely to be accepted (e.g. a documentationUrl option for each parameter)?

cc @maleck13 @philipgough

@jmrodri jmrodri self-assigned this Jun 5, 2018
@jmrodri
Copy link
Contributor

jmrodri commented Jun 5, 2018

@maleck13 to work on this

@maleck13
Copy link
Contributor

maleck13 commented Jun 5, 2018

@dimitraz discussed with the broker team. We will need to contact the UI team and see what can be achieved there. I think we can spike an approach to this and approach with our findings as this worked well for conditional params

from @shawn-hurley on that one, we may want to see if we could pass in something like markdown for them to render in the description of the parameter

@maleck13
Copy link
Contributor

Working with @dimitraz to do a poc on how this could work from UI and broker

@jmrodri jmrodri added 3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 and removed 3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 labels Jul 23, 2018
@jmrodri jmrodri added feature unplanned Issue is recognized but not planned for any release and removed 3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 labels Nov 12, 2018
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 29, 2020
@jmrodri
Copy link
Contributor

jmrodri commented Sep 20, 2020

/close

@openshift-ci-robot
Copy link

@jmrodri: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. unplanned Issue is recognized but not planned for any release
Projects
None yet
Development

No branches or pull requests

5 participants