Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused asbcli. #1125

Merged
merged 1 commit into from Oct 31, 2018
Merged

Remove unused asbcli. #1125

merged 1 commit into from Oct 31, 2018

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Oct 30, 2018

There is a vulnerability with the python requests package that asbcli depends on. asbcli is no longer supported and instead of going through trying to make it work with a newer python requests package, I opted to simply remove the offending code.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 30, 2018
@jmrodri jmrodri requested review from shawn-hurley and removed request for rthallisey October 30, 2018 14:22
Copy link
Contributor

@eriknelson eriknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time :D

Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmrodri jmrodri merged commit 83ef4d7 into master Oct 31, 2018
@jmrodri jmrodri deleted the fix-vulnerability-remove-asbcli branch February 1, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants