Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1765082: add registry-proxy support, bump bundle-lib #1253

Closed
wants to merge 3 commits into from
Closed

Bug 1765082: add registry-proxy support, bump bundle-lib #1253

wants to merge 3 commits into from

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Nov 5, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 5, 2019
@openshift-ci-robot
Copy link

@jmrodri: This pull request references Bugzilla bug 1765082, which is invalid:

  • expected dependent Bugzilla bug 1763005 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1765082: add registry-proxy support, bump bundle-lib

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2019
@coveralls
Copy link

coveralls commented Nov 5, 2019 •
edited

Coverage Status

Coverage remained the same at 40.97% when pulling 899c37e on bz1765082-fix-registry-proxy into dc49054 on release-4.2.

@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 12, 2019

/retest

@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 12, 2019

/test operator-molecule-olm-e2e

@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 12, 2019

/test operator-molecule-e2e

estroz
estroz approved these changes Nov 12, 2019
View reviewed changes
Copy link

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

once tests are fixed

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, jmrodri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@petr-muller
Copy link
Member

/hold

After three days of retesting, this does not look like a flake.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2019
@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 18, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019
@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 18, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 18, 2019
@openshift-ci-robot
Copy link

@jmrodri: This pull request references Bugzilla bug 1765082, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 19, 2019

/test operator-molecule-olm-e2e

@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 19, 2019

/test operator-molecule-e2e

1 similar comment
@jmrodri
Copy link
Contributor Author

jmrodri commented Dec 13, 2019

/test operator-molecule-e2e

@jmrodri
Copy link
Contributor Author

jmrodri commented Dec 19, 2019

/retest

1 similar comment
@shawn-hurley
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

@jmrodri: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/operator-molecule-olm-e2e 899c37e link /test operator-molecule-olm-e2e
ci/prow/operator-molecule-e2e 899c37e link /test operator-molecule-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabianvf
Copy link
Member

@jmrodri looks like we're starting to get bit by the python2 deprecation. Looks like more-itertools dropped python2 support recently: more-itertools/more-itertools#355 (comment)
which is why the build is failing with a syntax error on pip install: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_ansible-service-broker/1253/pull-ci-openshift-ansible-service-broker-release-4.2-operator-molecule-e2e/94#1:build-log.txt%3A309

We can pin the more-itertools version to 5.0.0 and that should get us past it for now

@jmrodri
Copy link
Contributor Author

jmrodri commented Feb 19, 2020

Closed won't fix

@jmrodri jmrodri closed this Feb 19, 2020
@jmrodri jmrodri deleted the bz1765082-fix-registry-proxy branch March 24, 2020 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jmrodri @openshift-ci-robot @coveralls @openshift-bot @petr-muller @shawn-hurley @fabianvf @estroz