Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect a config file to be mounted #211

Merged
merged 3 commits into from Jun 22, 2017

Conversation

fabianvf
Copy link
Member

rather than create one with sed based on environment variables

@jwmatthews
Copy link
Member

We need this for tech-preview.

@jwmatthews
Copy link
Member

ACK

Copy link
Contributor

@eriknelson eriknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Good catch @fabianvf

@eriknelson eriknelson merged commit 0e55807 into openshift:master Jun 22, 2017
@jmrodri
Copy link
Contributor

jmrodri commented Jun 22, 2017

this breaks make build-image, and make deploy. It also breaks the rpm build since we renamed build-config.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants