Put the broker creation inside deploy template

[djzager]

Update the broker template we use in this project (and in catasb) to
include the creation of the broker resource for the service catalog.
Also, update scripts that would attempt to create a broker that already
exists.

[djzager]

oc cluster up:

➜  ansible-service-broker git:(broker-in-template) oc cluster up --image=openshift/origin --version=v3.6.0 --service-catalog=true --routing-suffix=${ROUTING_SUFFIX} --public-hostname=${HOSTNAME}
Starting OpenShift using openshift/origin:v3.6.0 ...
OpenShift server started.

The server is accessible via web console at:
    https://172.17.0.1.nip.io:8443
...

Create the broker resources via template:

➜  ansible-service-broker git:(broker-in-template) oc new-project ansible-service-broker
Now using project "ansible-service-broker" on server "https://127.0.0.1:8443".

➜  ansible-service-broker git:(broker-in-template) oc process -f templates/deploy-ansible-service-broker.template.yaml -n ansible-service-broker \
-p DOCKERHUB_USER="changeme" \
-p DOCKERHUB_PASS="changeme" \
-p DOCKERHUB_ORG="ansibleplaybookbundle" \
-p ENABLE_BASIC_AUTH="false" | oc create -f -
service "asb" created
serviceaccount "asb" created
clusterrolebinding "asb" created
route "asb-1338" created
persistentvolumeclaim "etcd" created
deploymentconfig "asb" created
secret "asb-auth-secret" created
configmap "broker-config" created
broker "ansible-service-broker" created

Get the broker:

➜  ansible-service-broker git:(broker-in-template) oc get brokers ansible-service-broker -o yaml
apiVersion: servicecatalog.k8s.io/v1alpha1
kind: Broker
metadata:
  creationTimestamp: 2017-08-29T14:07:30Z
  finalizers:
  - kubernetes-incubator/service-catalog
  name: ansible-service-broker
  resourceVersion: "21"
  selfLink: /apis/servicecatalog.k8s.io/v1alpha1/brokersansible-service-broker
  uid: 651b9f17-8cc3-11e7-a7d5-0242ac110005
spec:
  authInfo:
    basicAuthSecret:
      name: asb-auth-secret
      namespace: ansible-service-broker
  url: https://asb-1338-ansible-service-broker.172.17.0.1.nip.io
status:
  conditions:
  - lastTransitionTime: 2017-08-29T14:07:48Z
    message: Successfully fetched catalog entries from broker.
    reason: FetchedCatalog
    status: "True"
    type: Ready

[jmrodri]

looks good, I had a question so marking as request changes.

[jmrodri]

did we need this? what's the case where this is http?

[djzager]

When rcm we use a different scheme http. I could actually remove this since it is the default in the template.

[jmrodri]

why didn't we just make the entire url a variable? and default it to https://asb-1338-ansible-service-broker.172.17.0.1.nip.io? I must be missing some critical information.

[djzager]

I did it this way to match up with asb_scheme and openshift_routing_suffix from catasb.

[djzager]

(2) Investigate if it’s possible to include creation of Broker resource inside of deployment template

[rthallisey]

Extra comment