Split the deploy.sh script to work with both kube & openshift #432
Conversation
rthallisey
requested review from
jmrodri,
abhgupta and
djzager
and removed request for
abhgupta
TestingThe gate uses |
rthallisey
force-pushed
the
split-deploy-scipts
branch
from
cec9cc0
to
ae7e74c
Compare
rthallisey
force-pushed
the
split-deploy-scipts
branch
from
ae7e74c
to
f736c0b
Compare
| ${VARS} | oc create -f - | ||
| if [[ "${KUBERNETES}" ]]; then | ||
| echo "Using Kubernetes" | ||
| "${BROKER_ROOT}/scripts/kubernetes/deploy.sh" |
There was a problem hiding this comment.
My recommendation is to bring in the scripts/kubernetes/deploy.sh and scripts/openshift/deploy.sh into this file.
There was a problem hiding this comment.
What I didn't want to do is turn these scripts into if k8s then do 100 things else openshift do these 100 things. With two separate files there's a clean separation because these are two separate scripts. So anything kubernetes related I know exists in scripts/kubernetes/.... It's not the best situation, but Bash isn't exactly the best for creating abstraction.
There was a problem hiding this comment.
@rthallisey +1 keep them separate. They will be easier to manage. Unless they are 100% the same, otherwise it will turn into a bunch of if kube else etc.
These two scripts are very different because one will use OpenShift templates and the other will use jinja2. I added an intermediate script that will direct to the proper location.
rthallisey
force-pushed
the
split-deploy-scipts
branch
from
f736c0b
to
83fe9da
Compare
| ${VARS} | oc create -f - | ||
| if [[ "${KUBERNETES}" ]]; then | ||
| echo "Using Kubernetes" | ||
| "${BROKER_ROOT}/scripts/kubernetes/deploy.sh" |
There was a problem hiding this comment.
@rthallisey +1 keep them separate. They will be easier to manage. Unless they are 100% the same, otherwise it will turn into a bunch of if kube else etc.
|
@djzager -1 to merging the files into one. |
These two scripts are very different because one will use OpenShift
templates and the other will use jinja2. I added an intermediate script
that will direct to the proper location.
Changes proposed in this pull request
make deployfor both openshift and kubernetes envs