Remove provision parameters from being reused as binding parameters. #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknelson
approved these changes
Sep 27, 2017
|
I thought this was put in for @jmontleon work. |
jmrodri
approved these changes
Sep 27, 2017
rthallisey
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, broker is listing all parameters intended for provision as binding parameters when creating a binding. Until binding parameters in the broker is implemented, we need to remove these parameters as they are not currently used and add confusion to the user experience.
Removes the service_binding.create paramaters and openshift_form_definition from the catalog request.