Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate a new ci framework for travis #463

Merged
merged 18 commits into from Nov 16, 2017

Conversation

rthallisey
Copy link
Contributor

Describe what this PR does and why we need it:
New ci framework will move away from have a set of bash scripts to run only mediawiki and postgresql. This framework will allow us to test any apb.

Changes proposed in this pull request

  • Pull in the new ci framework

@rthallisey
Copy link
Contributor Author

rthallisey commented Oct 2, 2017

Early WIP. Want to see travis run this.
Still investigating:

  • Running make run to compile to go binary probably isn't a best practice.
  • Creating the mediawiki and postgresql templates in their git repos.

@rthallisey rthallisey added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Oct 2, 2017
@rthallisey rthallisey force-pushed the new-ci-framework branch 8 times, most recently from 88dd8a6 to 553757f Compare October 5, 2017 15:20
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2017
@rthallisey rthallisey force-pushed the new-ci-framework branch 2 times, most recently from 3266ff6 to 4c12f65 Compare October 5, 2017 17:17
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2017
@rthallisey rthallisey force-pushed the new-ci-framework branch 2 times, most recently from fededf9 to f54d0e3 Compare October 6, 2017 12:24
@rthallisey
Copy link
Contributor Author

(25) CI Framework

1 similar comment
@rthallisey
Copy link
Contributor Author

(25) CI Framework

@rthallisey rthallisey force-pushed the new-ci-framework branch 2 times, most recently from fb24cbe to f182529 Compare October 10, 2017 18:51
@rthallisey rthallisey changed the title [WIP] New ci framework New ci framework Oct 11, 2017
@rthallisey rthallisey removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Oct 11, 2017
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 27, 2017
@jmrodri jmrodri added 3.8 do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. and removed needs-review labels Nov 3, 2017
@jmrodri
Copy link
Contributor

jmrodri commented Nov 3, 2017

We have decided per review to wait until Wednesday November 8th, 2017 before merging. At that point it will be ready to go.

@rthallisey rthallisey removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 10, 2017
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend 2 things for this PR but neither is required

  1. Clean up commit history
  2. Make title more descriptive for when this gets included in release notes.

@rthallisey rthallisey changed the title New ci framework Integrate a new ci framework for travis Nov 10, 2017
@rthallisey
Copy link
Contributor Author

Let's merge the ansibleplaybookbundle CI first so I can reference those templates in config.yaml

depends-on: ansibleplaybookbundle/postgresql-apb#7
depends-on: ansibleplaybookbundle/mediawiki-apb#8

Ryan Hallisey added 18 commits November 14, 2017 14:04
This repo should carry it's own config.yaml since it's a consumer
of the new framework.

Remove the local ci scripts and move the templates to the templates
directory.
- Add folded up broker an catalog logs to the end of a run
- Error properly when setup.sh fails
Verify the secret is created instead of the podpreset
We don't need the broker scripts anymore. We're moving to the new
framework.
Make these scripts individually consumable so the APB gates can
use them.
The gate job for the broker runs the asb with shell scripts.
Make sure we use catasb for non asb jobs.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 77a2ee7 on rthallisey:new-ci-framework into ** on openshift:master**.

@jmrodri
Copy link
Contributor

jmrodri commented Nov 16, 2017

Ok both dependent PRs were merged.

ansibleplaybookbundle/mediawiki-apb#8
ansibleplaybookbundle/postgresql-apb#7

Merging this now.

@jmrodri jmrodri merged commit 1d67572 into openshift:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants