Bug 1498618 - Support bind parameters. #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrodri
approved these changes
Oct 3, 2017
| * ASB Unit tests | ||
| * OpenShift UI form definition changes | ||
| * Experimental APB with async bind and passed parameters | ||
| * APB documentation changes (getting started / developer guide) |
There was a problem hiding this comment.
Normally the proposal is a separate PR done before the implementation :) But the proposal seems sane and it is very clear of your intentions. +1
| Free bool `json:"free,omitempty"` | ||
| Bindable bool `json:"bindable,omitempty"` | ||
| Parameters []ParameterDescriptor `json:"parameters"` | ||
| BindParameters []ParameterDescriptor `json:"bind_parameters,omitempty" yaml:"bind_parameters,omitempty"` |
| params["provision_params"] = *instance.Parameters | ||
| params := req.Parameters | ||
| if params == nil { | ||
| params = make(apb.Parameters) | ||
| } |
| @@ -171,10 +200,44 @@ func getType(paramType string) schema.PrimitiveTypes { | |||
| return []schema.PrimitiveType{schema.UnspecifiedType} | |||
| } | |||
|
|
|||
| func parametersToSchema(params []apb.ParameterDescriptor) Schema { | |||
| func parametersToSchema(plan apb.Plan) Schema { | |||
There was a problem hiding this comment.
Sane change to parametersToSchema. 👍
| @@ -76,18 +76,43 @@ var PlanParams = []apb.ParameterDescriptor{ | |||
| }, | |||
| } | |||
|
|
|||
| var PlanBindParams = []apb.ParameterDescriptor{ | |||
| { | |||
cfchase
added
the
do-not-merge
|
Added the |
cfchase
changed the title
cfchase
added
bug
and removed
do-not-merge
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support bind parameters. Proposal included.