Bug 1498185 - Adjust versioning check so that it is done in the registry package #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: This will fail travis until I update the upstream images so that they pass bootstrapping. Once I get approved reviews I will update the APBs and rerun travis. |
shawn-hurley
approved these changes
Oct 3, 2017
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
…try package (openshift#468) * Bug 1498185 - Move versioning check to spec validation within registry package * Update and add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts for the change of moving the APB spec version from an image label into the Spec itself. It also moves the version check out of the adapter package so that it is now obfuscated out of each individual adapter.
Changes proposed in this pull request
This PR fixes https://bugzilla.redhat.com/show_bug.cgi?id=1498185