rename ansibleapp to apb #47
Conversation
weird that goimports didn't format it the same as gofmt
* change header to be playbookbundles
|
I was able to provision with dockerhub, and was able to talk to the mock registry. |
|
In some places in the code |
|
@eriknelson some of the changes I made to |
| flags "github.com/jessevdk/go-flags" | ||
| yaml "gopkg.in/yaml.v1" | ||
| ) | ||
|
|
||
| type Args struct { | ||
| AppFile string `short:"a" long:"appfile" description:"Mock Ansible Apps yaml file"` | ||
| AppFile string `short:"a" long:"appfile" description:"Mock Ansible Playbook Bundles yaml file"` |
There was a problem hiding this comment.
Playbook Bundle/PlaybookBundle feels reasonable in place of "App" to me.
| // TODO: Is this required just to unwrap the root key and get the array? | ||
| // Load just an array without a root key to wrap it? | ||
| var parsedDat struct { | ||
| AnsibleApps []ansibleapp.Spec | ||
| PlaybookBundles []apb.Spec |
There was a problem hiding this comment.
Should we get more specific with "spec" files, such as BundleSpec?
There was a problem hiding this comment.
I like that BundleSpec would be nicer. I can make that change.
docs/aa_integration.md
Outdated
|
|
||
| ## Running AnsibleApps with the ASB | ||
| ## Running APB with the ASB |
There was a problem hiding this comment.
Keeping track of these two acronyms when referenced closely is going to get difficult :/
There was a problem hiding this comment.
I'll update the doc to be more clear. I'll make that PlaybookBundle instead.
|
@jmrodri RE: mock_registry.go changes, I don't expect |
* Added push functionality for adding APB spec to broker * Updated build to use spec image tag by default
* rename ansibleapp to apb * rename ansibleapp directory to apb * AnsibleApp to APB or Ansible Playbook Bundle * change to be apb * rename ansibleapp -> apb * change Ansible App to Ansible Playbook Bundle * change ansibleApp -> apb, AnsibleApp -> APB * AnsibleApp -> APB * IsAPB -> IsPlaybookBundle * fix formatting * rename ansibleapp to apb * fix docker registry * fix mock registry * change header to be playbookbundles * update diagrams to not say AnsibleApp * update comment
No description provided.