Bug 1497766 - Adding ablity to specify keeping namespace alive #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
changed the title
jmrodri
suggested changes
Oct 4, 2017
docs/config.md
Outdated
| @@ -159,6 +159,8 @@ registry: | |||
| | bearer_token_file | Location of bearer token to be used | N | | |||
| | image_pull_policy | When to pull the image | Y | | |||
| | sandbox_role | Role to give to apb sandbox environment | Y | | |||
| | keep_namespace | Always keep namespace after apb execution | N | | |||
| | Keep_namespace_on_error | Keep namespace after apb execution has an error | N | | |||
There was a problem hiding this comment.
entry should be lowercase Keep_namespace_on_error -> keep_namespace_on_error
docs/deployment.md
Outdated
| @@ -18,6 +18,8 @@ REGISTRY_URL | docker.io | Registry URL | |||
| DEV_BROKER | true | Include Broker Development Endpoint (true/false) | |||
| AUTO_ESCALATE | true | Auto escalate the users permissions when running an APB | |||
| BROKER_CA_CERT | "" | Tells the broker that the ca that has signed the SSL Cert and Key | |||
| KEEP_NAMESPACE | false | Always keep the APB namespace after execution. | |||
| KEEP_NAMESPACE_ON_ERROR | true | Keeps the APB namespace after a error during execution. | |||
etc/example-config.yaml
Outdated
| @@ -33,6 +33,8 @@ openshift: | |||
| bearer_token_file: "" | |||
| image_pull_policy: IfNotPresent | |||
| sandbox_role: "edit" | |||
| keep_namespace: false | |||
| keep_namespace_on_error: false | |||
There was a problem hiding this comment.
the deployment above shows keep_namespace_on_error = true, but in the example we default it to false.
There was a problem hiding this comment.
the default above needs to be false
pkg/apb/svc_acct.go
Outdated
| @@ -279,6 +287,19 @@ func (s *ServiceAccountManager) DestroyApbSandbox(executionContext ExecutionCont | |||
| return nil | |||
| } | |||
|
|
|||
| func shouldDeleteNamspace(clusterConfig ClusterConfig, pod *apicorev1.Pod, getPodErr error) bool { | |||
There was a problem hiding this comment.
TYPO: shouldDeleteNamspace -> shouldDeleteNamespace
shawn-hurley
added
the
do-not-merge
|
This needs to wait for the #464 to merge and then this implements that PR.
|
jmrodri
approved these changes
Oct 4, 2017
shawn-hurley
removed
the
do-not-merge
shawn-hurley
force-pushed
the
keep-namespace
branch
from
4b2fe9b
to
34e8e69
Compare
openshift-ci-robot
added
the
size/M
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
…hift#474) * adding ablity to specify keeping namespace alive * updating based on review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Keep namespace alive based on new configuration values
Changes proposed in this pull request
Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on
#464
CATASB PR: fusor/catasb#155
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes <issue_number>