Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove trailing spaces from supporting files #493

Merged
merged 1 commit into from
Oct 20, 2017
Merged

remove trailing spaces from supporting files #493

merged 1 commit into from
Oct 20, 2017

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Oct 15, 2017

Annoying trailing spaces removed.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2017
shawn-hurley
shawn-hurley approved these changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have added a trailing whitespace indicator to my setup as well, thanks for updating.

eriknelson
eriknelson approved these changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@eriknelson eriknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@eriknelson eriknelson added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-review labels Oct 16, 2017
@jmrodri jmrodri removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2017
@jmrodri jmrodri merged commit e35e301 into master Oct 20, 2017
@jmrodri jmrodri deleted the remove-trailing-spaces branch November 1, 2017 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknelson eriknelson eriknelson approved these changes

@shawn-hurley shawn-hurley shawn-hurley approved these changes

@rthallisey rthallisey rthallisey approved these changes

Assignees
No one assigned
Labels
docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmrodri @eriknelson @shawn-hurley @rthallisey @openshift-ci-robot