Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup tls support for k8s deployments #496

Merged
merged 7 commits into from Nov 14, 2017
Merged

Setup tls support for k8s deployments #496

merged 7 commits into from Nov 14, 2017

Conversation

rthallisey
Copy link
Contributor

@rthallisey rthallisey commented Oct 16, 2017 •
edited

Describe what this PR does and why we need it:
Change kubernetes template use bearer token auth.

Changes proposed in this pull request

  • Fixes kubernetes broker setup since bearer auth merged

Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on: fusor/catasb#164
partially-fixes: #233

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2017
jmrodri
jmrodri approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jmrodri
Copy link
Contributor

jmrodri commented Nov 3, 2017

@rthallisey can I merge this BEFORE the new ci framework?

@rthallisey rthallisey added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 3, 2017
@rthallisey
Copy link
Contributor Author

@jmrodri It's not ready yet

@rthallisey rthallisey added the 3.8 label Nov 7, 2017
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2017
@rthallisey rthallisey removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 10, 2017
djzager
djzager approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 26.319% when pulling 47032c3 on rthallisey:k8s-use-tls into 8dda327 on openshift:master.

@rthallisey rthallisey merged commit d313a67 into openshift:master Nov 14, 2017
@rthallisey rthallisey deleted the k8s-use-tls branch November 14, 2017 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@djzager djzager djzager approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Support both Openshift and Kubernetes
5 participants
@rthallisey @jmrodri @coveralls @djzager @openshift-ci-robot