Bug 1504250 - Keep listening for deprovision messages

[djzager]

Describe what this PR does and why we need it:

We want the subscriber to keep listening for deprovision messages even if a previous deprovision fails.

See https://bugzilla.redhat.com/show_bug.cgi?id=1504250 for recreation steps.

Before this change 'deprovision complete msg' would be sent to the channel but there would not be a corresponding 'processed deprovision message from buffer'.

After this change (from broker logs):

...
[2017-10-19T20:07:53.008Z] [DEBUG] sending deprovision complete msg to channel
[2017-10-19T20:07:53.008Z] [DEBUG] Processed deprovision message from buffer

[jmrodri]

The problem is we have return statements in the for loop of the go routine. Simply change those to continue. That is why making them a method worked for you because the return brought you back to the loop. I should've seen this in the deprovision review.

[jmrodri]

OR chain the if statements so they only do one of them at a time and no need for continue or return. See the provision subscriber. Either way is acceptable.

[jmrodri]

Um does not compile:

$ make build
go build -i -ldflags="-s -w" ./cmd/broker
# github.com/openshift/ansible-service-broker/pkg/broker
pkg/broker/deprovision_subscriber.go:60: undefined: log in log.Errorf
make: *** [Makefile:19: broker] Error 2

[djzager]

$ make build
go build -i -ldflags="-s -w" ./cmd/broker

$ make check
ok      github.com/openshift/ansible-service-broker/pkg/apb     0.190s
ok      github.com/openshift/ansible-service-broker/pkg/app     0.236s
ok      github.com/openshift/ansible-service-broker/pkg/auth    0.016s
ok      github.com/openshift/ansible-service-broker/pkg/broker  0.207s
?       github.com/openshift/ansible-service-broker/pkg/clients [no test files]
?       github.com/openshift/ansible-service-broker/pkg/dao     [no test files]
?       github.com/openshift/ansible-service-broker/pkg/fusortest       [no test files]
ok      github.com/openshift/ansible-service-broker/pkg/handler 0.309s
?       github.com/openshift/ansible-service-broker/pkg/metrics [no test files]
?       github.com/openshift/ansible-service-broker/pkg/origin/copy/authorization       [no test files]
ok      github.com/openshift/ansible-service-broker/pkg/origin/copy/authorization/validation    0.086s
?       github.com/openshift/ansible-service-broker/pkg/origin/copy/user        [no test files]
ok      github.com/openshift/ansible-service-broker/pkg/origin/copy/user/validation     0.081s
ok      github.com/openshift/ansible-service-broker/pkg/registries      0.079s
ok      github.com/openshift/ansible-service-broker/pkg/registries/adapters     0.102s
?       github.com/openshift/ansible-service-broker/pkg/runtime [no test files]
?       github.com/openshift/ansible-service-broker/pkg/version [no test files]