Bug 1502044 - add buffer size and work_engine test #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
shawn-hurley
approved these changes
Oct 26, 2017
| ft.AssertEqual(t, we.bufsz, 10) | ||
| } | ||
|
|
||
| func TestGetActiveTopics(t *testing.T) { |
rthallisey
reviewed
Oct 26, 2017
| ft.AssertEqual(t, "invalid work topic", err.Error(), "invalid error") | ||
| } | ||
|
|
||
| func TestStartNewJob(t *testing.T) { |
There was a problem hiding this comment.
This function still needed?
There was a problem hiding this comment.
@rthallisey I changed that test to actually do the test I was expecting. Should work now.
pkg/broker/work_engine_test.go
Outdated
|
|
||
| func (mw mockWorker) Run(token string, buffer chan<- WorkMsg) { | ||
| fmt.Println("xxxxxxxxxxxxxxxxxxxxx run called") | ||
| mw.called = true |
There was a problem hiding this comment.
The code where this gets used is commented out. Does TestStartNewJob need to be uncommented or should we remove the mockWorker struct?
There was a problem hiding this comment.
I'll clean that up. I think I wsa in the middle of creating a test that didn't quite work because I needed to mock something else.
rthallisey
approved these changes
Oct 31, 2017
during a refactoring of the work engines to support async deprovision and update we missed the buffer size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during a refactoring of the work engines to support async deprovision
and update we missed the buffer size.
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes 1502044