Bug 1504957 - Broker should use recreate strategy

[djzager]

Use the recreate strategy for the broker deployment.

[djzager]

Before Fix

$ oc logs asb-2-z4kg8 -c asb
Using config file mounted to /etc/ansible-service-broker/config.yaml
============================================================
==           Starting Ansible Service Broker...           ==
============================================================
[2017-10-20T15:09:13.108Z] [NOTICE] Initializing clients...
[2017-10-20T15:09:13.108Z] [DEBUG] Trying to connect to etcd
[2017-10-20T15:09:13.108Z] [INFO] == ETCD CX ==
[2017-10-20T15:09:13.108Z] [INFO] EtcdHost: 0.0.0.0
[2017-10-20T15:09:13.108Z] [INFO] EtcdPort: 2379
[2017-10-20T15:09:13.108Z] [INFO] Endpoints: [http://0.0.0.0:2379]
[2017-10-20T15:09:14.108Z] [ERROR] client: etcd cluster is unavailable or misconfigured; error #0: client: endpoint http://0.0.0.0:2379 exceeded header timeout

$ oc logs asb-2-deploy
--> Scaling up asb-2 from 0 to 1, scaling down asb-1 from 1 to 0 (keep 1 pods available, don't exceed 2 pods)
    Scaling asb-2 up to 1

This always fails because (from etcd's logs):

2017-10-20 14:49:08.881731 W | etcdserver: another etcd process is using "/data/member/snap/db" and holds the file lock.
2017-10-20 14:49:08.882677 W | etcdserver: waiting for it to exit before starting...

After Fix

$ oc rollout latest asb
deploymentconfig "asb" rolled out

$ oc logs -f dc/asb
--> Scaling asb-1 down to zero
--> Scaling asb-2 to 1 before performing acceptance check
--> Success

[jmrodri]

ACK