Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1506713 - handle updatable enum parameters properly in schema output #517

Merged
merged 1 commit into from Oct 27, 2017
Merged

Bug 1506713 - handle updatable enum parameters properly in schema output #517

merged 1 commit into from Oct 27, 2017

Conversation

jmontleon
Copy link
Contributor

Describe what this PR does and why we need it:

Changes proposed in this pull request

  • Make sure parameter types are specified for update

Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on N/A

Which issue this PR fixes (This will close that issue when PR gets merged)
fixes N/A

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2017
@jmrodri
Copy link
Contributor

jmrodri commented Oct 26, 2017

@jmontleon needs a bugzilla

@jmontleon jmontleon changed the title handle updatable enum parameters properly in schema output Fixes BZ#1506713 handle updatable enum parameters properly in schema output Oct 26, 2017
@jmontleon
Copy link
Contributor Author

@jmrodri
Copy link
Contributor

jmrodri commented Oct 26, 2017

Wrong PR title, needs to be Bug # - comment I will update it.

@jmrodri jmrodri changed the title Fixes BZ#1506713 handle updatable enum parameters properly in schema output Bug 1506713 - handle updatable enum parameters properly in schema output Oct 26, 2017
@jmrodri
Copy link
Contributor

jmrodri commented Oct 26, 2017

Please add a unit test to pkg/broker/util_test.go. Verify the Maxlength change, pattern and the enum.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2017
@jmontleon
Copy link
Contributor Author

@jmrodri missing anything else?

@jmontleon jmontleon merged commit a0eda5f into openshift:master Oct 27, 2017
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test! ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants