Bug 1476173 - Skip deprovision if the namespace is being deleted #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfchase
changed the title
openshift-ci-robot
added
the
size/S
shawn-hurley
requested changes
Oct 27, 2017
pkg/apb/deprovision.go
Outdated
| return false, err | ||
| } | ||
|
|
||
| return namespace == nil || namespace.Status.Phase == "Terminating", nil |
There was a problem hiding this comment.
Would prefer to use the constant to compare the value with.
There was a problem hiding this comment.
thanks, didn't realize that existed. Fixed
…e we can't access it and it's going to be deleted anyway.
jmrodri
approved these changes
Oct 28, 2017
shawn-hurley
approved these changes
Oct 29, 2017
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
…e we (openshift#520) can't access it and it's going to be deleted anyway.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip deprovision if the namespace is being deleted since we can't access it and it's going to be deleted anyway.