Bug 1476173 - Cleanup deleting namespaces #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
jmrodri
approved these changes
Nov 3, 2017
shawn-hurley
requested changes
Nov 3, 2017
| if ok, status, err := h.validateUser(userInfo.Username, serviceInstance.Context.Namespace); !ok { | ||
| writeResponse(w, status, broker.ErrorResponse{Description: err.Error()}) | ||
| return | ||
| if !nsDeleted { |
There was a problem hiding this comment.
Don't we need to check and not run the pod during unbind like deprovision?
There was a problem hiding this comment.
I haven't put this in for now, since I believe launch_apb_on_bind would have to be turned on. I can add it, as long as we think it's worth doing now.
| @@ -105,7 +105,7 @@ func setFailedDeprovisionJob(dao *dao.Dao, dmsg *DeprovisionMsg) { | |||
| } | |||
|
|
|||
| func cleanupDeprovision( | |||
| podName string, instance *apb.ServiceInstance, dao *dao.Dao, log *logging.Logger, | |||
it's terminating and clean up the data without executing the deprovision.
shawn-hurley
approved these changes
Nov 3, 2017
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
* Bug 1476173 - Skip user permission verification on namespace if it's terminating and clean up the data without executing the deprovision. * Bug 1476173 - Skipping apb launch on unbind if namespace is deleting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo deprovision of apbs in terminating namespaces to work when autoescalate is false. Skip user permission verification if the namespace is being deleted and clean up our etcd without running deprovision.