Bug 1504927 - if apbs fail, mark them as failed. #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
TEST failed provision marked as failed
|
TEST image pull
|
Provision an apb that will failImage pull failed provision |
jmrodri
requested review from
shawn-hurley,
eriknelson,
djzager and
rthallisey
|
Basically what's happening is that we were never looking at the failed text from the exec AND we ignored the error altogether. |
shawn-hurley
approved these changes
Nov 3, 2017
djzager
reviewed
Nov 3, 2017
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if bindOutput == nil { |
| @@ -61,12 +62,19 @@ func monitorOutput(namespace string, podname string, log *logging.Logger) ([]byt | |||
| credsNotAvailable := errors.New("exit status 2") | |||
|
|
|||
| output, err := runtime.RunCommand("kubectl", "exec", podname, gatherCredentialsCMD, "--namespace="+namespace) | |||
|
|
|||
| // cannot exec container, pod is done | |||
| podFailed := strings.Contains(string(output), "current phase is Failed") | |||
eriknelson
approved these changes
Nov 3, 2017
We were ignoring an error when an apb failed during provisioning and marking the apb as completed. This resulted in failed apbs looking as though they provisioned fine.
rthallisey
reviewed
Nov 3, 2017
| podCompleted := strings.Contains(string(output), "current phase is Succeeded") || | ||
| strings.Contains(string(output), "cannot exec into a container in a completed pod") | ||
|
|
||
| if err == nil { | ||
| log.Notice("[%s] Bind credentials found", podname) | ||
| return output, nil | ||
| } else if podFailed { | ||
| // pod has completed but is in failed state | ||
| log.Notice("[%s] APB failed", podname) |
There was a problem hiding this comment.
Should this be logged as an error?
rthallisey
approved these changes
Nov 3, 2017
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
* Bug 1504927 - if apbs fail, mark them as failed. We were ignoring an error when an apb failed during provisioning and marking the apb as completed. This resulted in failed apbs looking as though they provisioned fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were ignoring an error when an apb failed during provisioning and
marking the apb as completed. This resulted in failed apbs looking as
though they provisioned fine.
Which issue this PR fixes (This will close that issue when PR gets merged)
Fixes #506 - apb provisioning sets ServiceInstance as successful when apb fails
Fixes Bug 1504927 - ASB Failed provision marked successful even on pod error
Fixes Bug 1470851 - Image Pull Error is being marked as Success