Bug 1508724 - Look for the url in the proper place #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we look at Host in the url go pkg without http, the Host will show up empty. Instead, URL has a String() function that will give us the url we need. It returns: 'String reassembles the URL into a valid URL string'.
openshift-ci-robot
added
the
size/XS
shawn-hurley
approved these changes
Nov 3, 2017
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
If we look at Host in the url go pkg without http, the Host will show up empty. Instead, URL has a String() function that will give us the url we need. It returns: 'String reassembles the URL into a valid URL string'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
If we look at Host in the url go pkg without http, the Host
will show up empty. Instead, URL has a String() function that
will give us the url we need. It returns: 'String reassembles
the URL into a valid URL string'.