Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1508724 - Fixing RHCC registry name #539

Merged
merged 1 commit into from Nov 6, 2017

Conversation

shawn-hurley
Copy link
Contributor

Describe what this PR does and why we need it:
.String() will add the scheme to the URL. We will need to ignore that, therefore if the Host value is not set, the Path vale will be set.

example:
https://play.golang.org/p/5UrBpwtNeA

Which issue this PR fixes (This will close that issue when PR gets merged)
fixes bz#1508724

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2017
Copy link
Contributor

@rthallisey rthallisey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to drop the scheme for the image name.

Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jmrodri jmrodri added the bug label Nov 6, 2017
@rthallisey rthallisey merged commit 37a77b6 into openshift:master Nov 6, 2017
jianzhangbjz pushed a commit to jianzhangbjz/ansible-service-broker that referenced this pull request May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants