Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded paragraph from license header #549

Merged
merged 1 commit into from Nov 11, 2017
Merged

remove unneeded paragraph from license header #549

merged 1 commit into from Nov 11, 2017

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Nov 11, 2017

We were asked to remove the unneeded paragraph regarding trademarks as it was older language that is no longer used. I copied the original header from some old code :)

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 11, 2017
@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 11, 2017

TEST

  • make sure everything compiles and builds.
  • inspect the diff ensure that there is only either a NEW addition of the header OR the trademark paragraph was removed.

FAIL if you see any CODE that was removed because that means it probably didn't have a header to begin with. I didn't see any but I want extra eyes on it.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling eccd096 on fixheader into ** on master**.

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djzager djzager merged commit 5426d5e into master Nov 11, 2017
@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 11, 2017

@jmrodri jmrodri deleted the fixheader branch December 15, 2017 15:53
jianzhangbjz pushed a commit to jianzhangbjz/ansible-service-broker that referenced this pull request May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tech-debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants