using table driven testing #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
jmrodri
requested review from
eriknelson,
djzager,
shawn-hurley and
rthallisey
jmrodri
added
3.8
do-not-merge
|
Let me know what folks think. It might be better for the more advanced tests. |
openshift-ci-robot
added
size/L
|
These look reasonable to me. 👍 |
shawn-hurley
approved these changes
Nov 14, 2017
|
@maleck13 thanks for the enlightenment. I never knew you could do this. Once you get the hang of it, it's quite easy to understand and read. 👍 |
djzager
approved these changes
Nov 14, 2017
jmrodri
removed
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a table driven test case similar to what @maleck13 has proposed. This is using an existing test to see how it compares.