adding ability to connnect over SSL w/o authentication. #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
shawn-hurley
added
bug
needs-review
and removed
size/XS
|
Changes Unknown when pulling 95467e8 on shawn-hurley:issue-554 into ** on openshift:master**. |
shawn-hurley
added
do-not-merge/work-in-progress
|
I am going to add some test cases around the etcd_client. |
openshift-ci-robot
added
the
size/L
shawn-hurley
added
needs-review
and removed
do-not-merge/work-in-progress
|
Changes Unknown when pulling 2d2b367 on shawn-hurley:issue-554 into ** on openshift:master**. |
eriknelson
approved these changes
Nov 16, 2017
|
Changes Unknown when pulling 7fcce72 on shawn-hurley:issue-554 into ** on openshift:master**. |
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
* adding ability to connnect over SSL w/o authentication. * Adding test coverage for etcd client. * adding testing for etcd version. * adding coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Allows the broker to only connect over TLS while etcd authentication is off.
Changes proposed in this pull request
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #554