New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Kubernetes Client struct #561
Conversation
|
Changes Unknown when pulling 6107cc3 on rthallisey:kube-client into ** on openshift:master**. |
In the Clients pkg, each of the clients should have a Class to reference. This creates the Kubernetes class reference so we can build specific Kubernetes functions into the client class.
6107cc3
to
7a5ef4a
Compare
|
Changes Unknown when pulling 7a5ef4a on rthallisey:kube-client into ** on openshift:master**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My fault, I saw this yesterday and forgot to comment.
* Create a Kubernetes Client struct In the Clients pkg, each of the clients should have a Class to reference. This creates the Kubernetes class reference so we can build specific Kubernetes functions into the client class. * Fix lint test
Describe what this PR does and why we need it:
In the Clients pkg, each of the clients should have a Class to
reference. This creates the Kubernetes class reference so we
can build specific Kubernetes functions into the client class.
Changes proposed in this pull request
Partially-fixes: #233