Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Kubernetes Client struct #561

Merged
merged 2 commits into from Nov 17, 2017

Conversation

rthallisey
Copy link
Contributor

@rthallisey rthallisey commented Nov 16, 2017

Describe what this PR does and why we need it:
In the Clients pkg, each of the clients should have a Class to
reference. This creates the Kubernetes class reference so we
can build specific Kubernetes functions into the client class.

Changes proposed in this pull request

  • Add a Kubernetes class to the client pkg

Partially-fixes: #233

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 16, 2017
@rthallisey rthallisey added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 16, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6107cc3 on rthallisey:kube-client into ** on openshift:master**.

Ryan Hallisey added 2 commits November 16, 2017 15:55
In the Clients pkg, each of the clients should have a Class to
reference.  This creates the Kubernetes class reference so we
can build specific Kubernetes functions into the client class.
@rthallisey rthallisey removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 16, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7a5ef4a on rthallisey:kube-client into ** on openshift:master**.

@rthallisey
Copy link
Contributor Author

Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My fault, I saw this yesterday and forgot to comment.

@rthallisey rthallisey merged commit 4f0b431 into openshift:master Nov 17, 2017
@rthallisey rthallisey deleted the kube-client branch November 17, 2017 17:40
jianzhangbjz pushed a commit to jianzhangbjz/ansible-service-broker that referenced this pull request May 17, 2018
* Create a Kubernetes Client struct

In the Clients pkg, each of the clients should have a Class to
reference.  This creates the Kubernetes class reference so we
can build specific Kubernetes functions into the client class.

* Fix lint test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Support both Openshift and Kubernetes
5 participants