Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase k8s templates to pickup etcd name change #563

Merged
merged 1 commit into from Nov 20, 2017

Conversation

rthallisey
Copy link
Contributor

@rthallisey rthallisey commented Nov 17, 2017

Describe what this PR does and why we need it:
After the etcd ssl work landed, the broker and etcd
pods were split and the etcd deployment name changed.
Realign the k8s templates with those changes.

Changes proposed in this pull request

  • Have k8s use the same resources names as the openshift templates

Partially-fixes: #233

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2017
With the addition of etcd ssl, the broker and etcd
pods were split and the etcd deployment name changed.
Realign the k8s templates with those changes.
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 30943c3 on rthallisey:k8s-etcd-name into ** on openshift:master**.

Copy link
Contributor

@eriknelson eriknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VISIACK

@eriknelson eriknelson merged commit c4a90fb into openshift:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Support both Openshift and Kubernetes
6 participants