Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give cluster client the log object #565

Merged
merged 1 commit into from Nov 21, 2017

Conversation

rthallisey
Copy link
Contributor

Revert a portion of the k8s struct patch. We need to pass the log object in for each call.

Revert a portion of the k8s class patch.
We need to pass the log object in for each call.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2017
Copy link
Contributor

@eriknelson eriknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Note: we're expecting to refactor the logging across the project with a follow-up pr.

@coveralls
Copy link

coveralls commented Nov 20, 2017

Coverage Status

Changes Unknown when pulling 5bf306b on rthallisey:add-logging-back into ** on openshift:master**.

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rthallisey rthallisey merged commit d1e65fa into openshift:master Nov 21, 2017
@rthallisey rthallisey deleted the add-logging-back branch November 21, 2017 23:12
jianzhangbjz pushed a commit to jianzhangbjz/ansible-service-broker that referenced this pull request May 17, 2018
Revert a portion of the k8s class patch.
We need to pass the log object in for each call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants