docs and ci template updates for apb name changes #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
size/S
djzager
reviewed
Dec 4, 2017
| @@ -3,7 +3,7 @@ kind: ServiceInstance | |||
| metadata: | |||
| name: mediawiki123 | |||
| spec: | |||
| clusterServiceClassExternalName: dh-mediawiki123-apb | |||
| clusterServiceClassExternalName: dh-mediawiki-apb | |||
There was a problem hiding this comment.
If our ci is using the templates inside their relative projects...do we still need these templates? or the associated steps in cleanup-ci.sh?
It looks like we moved to the new CI, but the remnants hanging around may make life more confusing down the road.
There was a problem hiding this comment.
I left this around so folks can run oc create -f templates/mediawiki.yaml and test things by hand. cleanup-ci.sh does use them, but it doesn't have to.
|
Changes Unknown when pulling e487c7b on jmontleon:apb-name-changes into ** on openshift:master**. |
|
Changes Unknown when pulling 4ff4c40 on jmontleon:apb-name-changes into ** on openshift:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Changes proposed in this pull request
Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes <issue_number>