Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1510486 - Return 403 for disallowed actions #586

Merged
merged 1 commit into from Dec 11, 2017

Conversation

shawn-hurley
Copy link
Contributor

Describe what this PR does and why we need it:
Updating the status code for when a user does not have access to do an apb action

Which issue this PR fixes (This will close that issue when PR gets merged)
fixes bug 1510486

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2017
@jmrodri
Copy link
Contributor

jmrodri commented Dec 11, 2017

Consider shortening the commit message. The problem is it will get cut off. How about:

Bug 1510486 - Return 403 for disallowed actions

Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jmrodri jmrodri changed the title Bug 1510486- Adding correct error code for when user is not allowed to do an action. Bug 1510486 - Adding correct error code for when user is not allowed to do an action. Dec 11, 2017
@shawn-hurley shawn-hurley changed the title Bug 1510486 - Adding correct error code for when user is not allowed to do an action. Bug 1510486 - Return 403 for disallowed actions Dec 11, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5fc08a3 on shawn-hurley:bug-1510486 into ** on openshift:master**.

@jmrodri jmrodri merged commit 281a83e into openshift:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants