Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading dependancies to K8s 1.8.5 #589

Merged
merged 5 commits into from Dec 14, 2017
Merged

Upgrading dependancies to K8s 1.8.5 #589

merged 5 commits into from Dec 14, 2017

Conversation

shawn-hurley
Copy link
Contributor

Describe what this PR does and why we need it:
This PR will upgrade our dependencies for k8s 1.8.
This PR is needed for completing the API for remote execution.

Changes proposed in this pull request

  • bump versions of k8s dependencies
  • update code that was using deprecated code paths
  • general clean up of the glide file.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 13, 2017
@shawn-hurley shawn-hurley added needs-review tech-debt and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2017
@shawn-hurley
fixing our code to use k8s 1.8 api changes.
d35025d 
updating comments for the TODOs and knowledge in the future.
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 13, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d35025d on shawn-hurley:k8s-upgrade into ** on openshift:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d35025d on shawn-hurley:k8s-upgrade into ** on openshift:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d35025d on shawn-hurley:k8s-upgrade into ** on openshift:master**.

@djzager
Copy link
Member

djzager commented Dec 13, 2017

This looks good to me. I am holding my 👍 until I test it locally, probably after lunch but before the end of the day.

@shawn-hurley
Copy link
Contributor Author

Integrate remote execution for v1 (backwards compat) credential extraction.

djzager
djzager approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coveralls
Copy link

coveralls commented Dec 13, 2017 •
edited

Coverage Status

Changes Unknown when pulling 064fd60 on shawn-hurley:k8s-upgrade into ** on openshift:master**.

@shawn-hurley
Copy link
Contributor Author

Travis seems to not want to run the test against the latest changes. I have no idea why, you can see these files do not violate the lint if you look at them. I propose we ignore the lint issue that CI is failing on.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 61f448a on shawn-hurley:k8s-upgrade into ** on openshift:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b15a9c7 on shawn-hurley:k8s-upgrade into ** on openshift:master**.

@rthallisey rthallisey merged commit cf6c317 into openshift:master Dec 14, 2017
jianzhangbjz pushed a commit to jianzhangbjz/ansible-service-broker that referenced this pull request May 17, 2018
@shawn-hurley
Upgrading dependancies to K8s 1.8.5 (openshift#589)
c3cf7af 
* vendor and glide changes for upgrade to k8s 1.8

* fixing our code to use k8s 1.8 api changes.

updating comments for the TODOs and knowledge in the future.

* fixing tests

* gate debugging

* removing gate debug and fixing lint issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

@rthallisey rthallisey rthallisey approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@eriknelson eriknelson Awaiting requested review from eriknelson

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shawn-hurley @coveralls @djzager @rthallisey @openshift-ci-robot