allows parameter types to be case-insensitive #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message when failing to parse a spec is improved to include the name of the spec. fixes openshift#592
openshift-ci-robot
added
the
size/XS
|
Changes Unknown when pulling 30e6ad3 on mhrivnak:lowercase-param-types into ** on openshift:master**. |
rthallisey
approved these changes
Dec 19, 2017
shawn-hurley
requested changes
Dec 19, 2017
| @@ -196,7 +197,7 @@ func createUIFormItem(pd apb.ParameterDescriptor, paramIndex int) (interface{}, | |||
|
|
|||
| // getType transforms an apb parameter type to a JSON Schema type | |||
| func getType(paramType string) (schema.PrimitiveTypes, error) { | |||
| switch paramType { | |||
| switch strings.ToLower(paramType) { | |||
There was a problem hiding this comment.
Can we add a test case for this? util_test.go:371 should be the test cases to add to?
There was a problem hiding this comment.
Do you have something in mind that's more than what I already added there?
There was a problem hiding this comment.
...
{"number", schema.NumberType},
{"NUMBER", schema.NumberType},
{"nil", schema.NullType},
...Add that to line 385ish in pkg/broker/util_test.go
|
@mhrivnak I am re-running the Gate test after the apb base fix that we merged yesterday. |
shawn-hurley
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message when failing to parse a spec is improved to include the name
of the spec.
fixes #592