Adding local openshift adapter #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
shawn-hurley
approved these changes
Dec 19, 2017
|
Thanks for the PR! |
|
Changes Unknown when pulling d682c68 on matzew:Local_openshift_adapter into ** on openshift:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
The PR adds the local openshift adapter to the template.
Problem is, with the
masterversion of thetemplates/deploy-ansible-service-broker.template.yaml, and thescripts/run_latest_build.shfiles, it is not possible to perform anapb push(with latest apb-tools).The call succeeds, but the apb is not added.
On IRC @shawn-hurley told me that it's because I dont have the local openshift adapter.
So I am adding it here
Changes proposed in this pull request
Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on
nope
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes <issue_number>