Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the different job msg types to avoid duplication of code #603

Merged

Conversation

maleck13
Copy link
Contributor

Describe what this PR does and why we need it:

There were 3 different JobMsg types being used however they were all essentially the same barring one field and all consumers of the type were using the interface: WorkMsg

Changes proposed in this pull request

  • remove the provisionmsg, deprovisionmsg and updatemsg type and replace them with a single jobmsg type

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 27, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 804e26f on maleck13:condense-job-msgs-into-single-type into ** on openshift:master**.

@maleck13
Copy link
Contributor Author

While looking into #475 I noticed the different job msg types were all the same and that the specific type was not being used for anything so seemed to make sense to merge them into a single type

@jmrodri jmrodri self-requested a review January 2, 2018 01:15
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original idea was to have different types for each of the subscribers, but as you have noticed they were just copies of each other. I'm ok with this change. I'm merging this so I can have this incorporated into my async bind work.

@jmrodri jmrodri merged commit 4a4016c into openshift:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants