Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The config should only use type as a key when name does not exist. #606

Merged
merged 1 commit into from
Jan 2, 2018

Conversation

shawn-hurley
Copy link
Contributor

@shawn-hurley shawn-hurley commented Jan 2, 2018

Describe what this PR does and why we need it:
This fixes a bug in the configuration package that caused multiple registries to be initialized.
Changes proposed in this pull request

  • make it so that you don't use both keys of name and type, but rather name then type.
  • remove debug statement that should be removed.

Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #605

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2018
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4929ffc on shawn-hurley:bug-605 into ** on openshift:master**.

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@shawn-hurley shawn-hurley merged commit b5b9a0c into openshift:master Jan 2, 2018
jianzhangbjz pushed a commit to jianzhangbjz/ansible-service-broker that referenced this pull request May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple registries are created and initialized for a single registry defined in the config
5 participants