Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect check in if statement #611

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

maleck13
Copy link
Contributor

@maleck13 maleck13 commented Jan 4, 2018

Describe what this PR does and why we need it:
in last operation there was an incorrect if statement causes excess logging

job state has an error. Assuming that any error here is human readable. err - 

Changes proposed in this pull request

  • fix the if statement so it only logs if there is an error

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 4, 2018
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 me: 🤦‍♂️

@coveralls
Copy link

coveralls commented Jan 4, 2018

Coverage Status

Changes Unknown when pulling 61e78ca on maleck13:minor-bug-fix into ** on openshift:master**.

@rthallisey rthallisey merged commit 2d53f92 into openshift:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants