Use the router prefix for apb tool endpoints #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using the same routing prefix for the apb tool endpoints
openshift-ci-robot
added
the
size/XS
shawn-hurley
reviewed
Jan 5, 2018
| h.router.HandleFunc("/apb/spec", createVarHandler(h.apbRemoveSpecs)).Methods("DELETE") | ||
| s.HandleFunc("/v2/apb", createVarHandler(h.apbAddSpec)).Methods("POST") | ||
| s.HandleFunc("/v2/apb/{spec_id}", createVarHandler(h.apbRemoveSpec)).Methods("DELETE") | ||
| s.HandleFunc("/v2/apb", createVarHandler(h.apbRemoveSpecs)).Methods("DELETE") |
There was a problem hiding this comment.
are we intentionally droping the /spec and including this in .../v2/... now?
There was a problem hiding this comment.
I was thinking we could do that going forward. Do you think we should keep it as is?
There was a problem hiding this comment.
no real opinion either way. This will need follow up PRs for the APB tool I think if we do make the change. Other than that it LGTM
|
Changes Unknown when pulling ef6d90d on rthallisey:apb-tool-endpoints into ** on openshift:master**. |
shawn-hurley
approved these changes
Jan 5, 2018
dymurray
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Switch to using the same routing prefix for the apb tool endpoints. The apb tool has all the information needed to use these endpoints.
Which issue this PR fixes (This will close that issue when PR gets merged)
partially: ansibleplaybookbundle/ansible-playbook-bundle#180