Bug 588 - Run latest build with a default public ip. #626
Conversation
openshift-ci-robot
added
the
size/XS
|
Changes Unknown when pulling 9f28dae on shawn-hurley:bug-588 into ** on openshift:master**. |
scripts/run_latest_build.sh
Outdated
| @@ -34,7 +34,7 @@ | |||
| # | |||
|
|
|||
| DOCKER_IP="$(ip addr show docker0 | grep -Po 'inet \K[\d.]+')" | |||
| PUBLIC_IP=${PUBLIC_IP:-$DOCKER_IP} | |||
There was a problem hiding this comment.
It looks like there used to be some hope that PUBLIC_IP had already been set. Is that still true? Or is it safe to assume that it is never set until this moment, or at least we are happy always overwriting any prior value?
There was a problem hiding this comment.
I followed the getting started docs and saw nothing about setting the PUBLIC_IP. Basically, the mac has to have a default that will be set to fix the bug. If there is some better way, checking if PUBLIC_IP is already set, then checking DOCKER_IP and then a defaulting I wouldn't mind doing that. I would need some direction though for that :)
There was a problem hiding this comment.
Gotcha, ok. I have no idea if it's important, but just noticed that it was a change in behavior. If you're happy with the behavior, I'm happy. :)
That said, IF it was valuable to use a previously-set PUBLIC_IP, I think you could add a line above this one, and revert this line's change:
DOCKER_IP=${DOCKER_IP:-127.0.0.1}
|
Changes Unknown when pulling 51307a0 on shawn-hurley:bug-588 into ** on openshift:master**. |
shawn-hurley
added
the
3.9 | release-1.1
Describe what this PR does and why we need it:
This PR will default the
PUBLIC_IPto the localhost.This value will allow for macOS to have this value because it can not find the docker interface
docker0.The issue that used to exist where the service catalog could not contact the broker is no longer a concern
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #588