Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1533208 - Re adding registry auth as secrets and files #629

Merged
merged 3 commits into from Jan 11, 2018

Conversation

shawn-hurley
Copy link
Contributor

  • This was in place and was changed most likely due to a bad rebase.

Describe what this PR does and why we need it:

Changes proposed in this pull request

  • Re-adding getting of secrets if auth type is secret
  • Re-adding of getting of secrets from file if auth type is file
  • Re-adding dealing with plain text config auth

Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on
This is tied to PR: #628
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes BZ 1533208

This was intially added in PR: #502

* This was in place and was changed most likely due to a bad rebase.
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2018
@shawn-hurley shawn-hurley added bug 3.9 | release-1.1 Kubernetes 1.9 | Openshift 3.9 | Broker release-1.1 labels Jan 10, 2018
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shawn!

@coveralls
Copy link

coveralls commented Jan 10, 2018

Coverage Status

Changes Unknown when pulling 5d00786 on shawn-hurley:reapply-secret-reg-auth into ** on openshift:master**.

@coveralls
Copy link

coveralls commented Jan 10, 2018

Coverage Status

Changes Unknown when pulling 3570d33 on shawn-hurley:reapply-secret-reg-auth into ** on openshift:master**.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2018
@coveralls
Copy link

coveralls commented Jan 10, 2018

Coverage Status

Changes Unknown when pulling 0c7f039 on shawn-hurley:reapply-secret-reg-auth into ** on openshift:master**.

@rthallisey rthallisey merged commit 29a7f1e into openshift:master Jan 11, 2018
jianzhangbjz pushed a commit to jianzhangbjz/ansible-service-broker that referenced this pull request May 17, 2018
…#629)

* Bug 1533208 - Re adding registry auth as secrets and files

* This was in place and was changed most likely due to a bad rebase.

* testing travis with the PR.

* fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.9 | release-1.1 Kubernetes 1.9 | Openshift 3.9 | Broker release-1.1 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants