Add proxy docs #634
Merged
Add proxy docs #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
Changes Unknown when pulling 282e7bf on eriknelson:proxy-docs into ** on openshift:master**. |
openshift-ci-robot
added
the
do-not-merge/work-in-progress
eriknelson
force-pushed
the
proxy-docs
branch
from
282e7bf
to
2aa7d5c
Compare
openshift-ci-robot
added
size/M
eriknelson
added
docs
needs-review
3.9 | release-1.1
|
Changes Unknown when pulling 2aa7d5c on eriknelson:proxy-docs into ** on openshift:master**. |
eriknelson
force-pushed
the
proxy-docs
branch
from
2aa7d5c
to
63a8350
Compare
|
Changes Unknown when pulling 63a8350 on eriknelson:proxy-docs into ** on openshift:master**. |
docs/proxy.md
Outdated
|
|
||
| Finally, it's possible the services spawned by the APB may also require external | ||
| network access via proxy. The APB *must* be authored to set these environment variables | ||
| explicitly if if recognizes them in its own execution environment, or the cluster |
There was a problem hiding this comment.
Dup "if" in here: "f if recognizes them"
|
@eriknelson Others LGTM. Thx. |
jmrodri
suggested changes
Jan 22, 2018
docs/proxy.md
Outdated
|
|
||
| It is recommended to review the [Openshift Documentation ](https://docs.openshift.com/container-platform/3.7/install_config/http_proxies.html) | ||
| and to configure a cluster accordingly before attempting to run the broker behind | ||
| a proxy. When running an Ansible Service Broker inside of a proxied Openshift cluster, |
There was a problem hiding this comment.
Probably best to start using "Ansible Broker".
TYPO: Openshift should be OpenShift.
docs/proxy.md
Outdated
| [edit the broker's DeploymentConfig and set the HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment variables](https://docs.openshift.com/container-platform/3.7/install_config/http_proxies.html#setting-environment-variables-in-pods). | ||
| It's common that APB pods themselves may require external access via proxy as well. | ||
| If the broker recognizes it has a proxy configuration, it will transparently | ||
| apply this env vars to the APB pods that it spawns. As long as the modules used |
jmrodri
approved these changes
Jan 25, 2018
eriknelson
force-pushed
the
proxy-docs
branch
from
742b004
to
dfb5325
Compare
eriknelson
force-pushed
the
proxy-docs
branch
from
dfb5325
to
479cbe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.