Bug 1526949 - Set registry user/pass if auth_type is not defined #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
shawn-hurley
approved these changes
Jan 12, 2018
jmrodri
approved these changes
Jan 12, 2018
| password = "" | ||
| // Assuming that the user has either no credentials or defined them in the config | ||
| username = reg.User | ||
| password = reg.Pass |
|
Changes Unknown when pulling 49fe2d6 on dymurray:bz1526949 into ** on openshift:master**. |
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Does not wipe out user/pass credentials just because the user didn't set auth_type. Later down the line we can explicity require auth_type if desired but it's not intuitive to set that value for long time users. This bit QE and the code was not in master for awhile so we weren't seeing this.
Changes proposed in this pull request