Bug 1534715 - unbind checks for existence of binding before trying to delete it #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
Changes Unknown when pulling d33b2ad on mhrivnak:fix-unbind-multiple-apbs into ** on openshift:master**. |
jmrodri
suggested changes
Jan 15, 2018
pkg/broker/broker.go
Outdated
| if err != nil { | ||
| if client.IsKeyNotFound(err) { | ||
| return nil, ErrorNotFound | ||
| } else { |
There was a problem hiding this comment.
remove the else block
if client.IsKeyNotFound(err) {
return nil, ErrorNotFound
}
return nil, err… delete it Unbind was not checking this previously. When doing an async unbind, this meant multiple APBs got launched. Additionally, all but the first DELETE requests were geting a 500 response code due to incorrect handling of "err" in code. fixes openshift#640
mhrivnak
force-pushed
the
fix-unbind-multiple-apbs
branch
from
d33b2ad
to
91e832c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbind was not checking this previously. When doing an async unbind, this meant
multiple APBs got launched. Additionally, all but the first DELETE requests
were geting a 500 response code due to incorrect handling of "err" in code.
fixes #640